Spanning Data From MySQL Across Multiple pages

[leprechaun13]

wrote a stats script recently and its got to 550ish hits and takin a while to load so trying to spread it across multiple pages got it to do it with this script fine but it puts the page numbers backwards.

script here

        $page = $_GET['page'];

        $limit= "20";
        
        $action = $_GET['action'];
        
        $select = "SELECT * from visitors";
        
        $result = mysql_query($select);
        
        $num = mysql_num_rows($result);
        
        $num = $num / 30;
        
        $num = ceil($num);
        
        $start = (($page - 1) * ($limit) + 1);
        
            echo "<b>Page:</b>";
        while ( $num >= 1) {
    echo <<<END
    <a href="?action=$action&page=$num">$num</a>
END;
    $num--;
    } 

how would i get the numbers to order 1 2 3 4 rather than 4 3 2 1

[bfsog]

First off, the script is pretty inefficient. You are selecting all columns and all rows, whereas you could use COUNT to simply return the number of rows.

Second off, the way the script is coded, $num will always start above 1 (assuming you have > 1 rows). Add another variable to the mix, and change the logic to

$i = 0;
while ($i < $num)
  {
    echo $i;
    $i++;
  } 

[Shadowfiend]

Yes, you definitely want to take bfsog's advice and use COUNT. Something like this:

$res = mysql_query("SELECT COUNT(*) AS count FROM table", $cxn);
$res = mysql_fetch_assoc($res);
$count = $res['count']; 

[ljm]

First off, the script is pretty inefficient. You are selecting all columns and all rows, whereas you could use COUNT to simply return the number of rows.

Second off, the way the script is coded, $num will always start above 1 (assuming you have > 1 rows). Add another variable to the mix, and change the logic to

$i = 0;
while ($i < $num)
  {
    echo $i;
    $i++;
  } 

Wouldn't it be more efficient to use a for loop rather than a while loop? ie.

for ($i = 0; $i < $num; $i++) {
echo $i;
} 

Not sure if it's worth bothering with, mind; I might just be being pedantic

[Shadowfiend]

Well, that's what for loops are designed for, so yes

[leprechaun13]

so would this be more efficient then?

<?php
include 'config.php';

$page = $_GET['page'];

        $limit= "20";
        
        $action = $_GET['action'];
        
        $res = mysql_query("SELECT COUNT(*) AS count FROM visitors");
        
        $res1 = mysql_fetch_assoc($res);
        
        $count = $res1['count'];  
        
        $num = $count / 30;
        
        $num = ceil($num);
        
        $start = (($page - 1) * ($limit) + 1);
        

        $i = 1;
while ($i <= $num)
  {
    echo "<a href='?action=$action&page=$i'>$i</a> ";
    $i++;
  }

[Shadowfiend]

Yep, that looks about right.

[leprechaun13]

ah cheers for the help all