Register

If this is your first visit, please click the Sign Up now button to begin the process of creating your account so you can begin posting on our forums! The Sign Up process will only take up about a minute of two of your time.

Results 1 to 4 of 4
Like Tree1Likes
  • 1 Post By Ronald Roe

Thread: CSS Grid Layout- Does this seem right?

  1. #1
    Junior Member
    Join Date
    Dec 2016
    Posts
    17
    Member #
    55967
    Liked
    1 times

    CSS Grid Layout- Does this seem right?

    Hey guys, any thoughts about this? Its seems good, but since I'm still learning, I'm sure I've missed some things. May be a better more efficient way of doing it? Thanks.Grid example1.jpgGrid example2.jpg

  2.  

  3. #2
    Senior Member Ronald Roe's Avatar
    Join Date
    Mar 2011
    Location
    Oklahoma City
    Posts
    3,141
    Member #
    27197
    Liked
    959 times
    Looks good to me. I will say, when you are setting a background color or image, it's best to set them explicitly. Oddly, when you use shorthand, it sets a lot of defaults that aren't the same as the default browser styles, and may cause further issues down the line if another selector overwrites those values.

    I can't find the original article I read, which explains it much better and with really good examples, but I did find this one that does an overall adequate job of it: https://csswizardry.com/2016/12/css-...-anti-pattern/

    Probably not a real issue in a small learning project like this, but something to keep in mind as you step into real world projects.
    ScottAC likes this.
    Ron Roe
    Web Developer
    "If every app were designed using the same design template, oh wait...Bootstrap."

  4. #3
    Junior Member
    Join Date
    Dec 2016
    Posts
    17
    Member #
    55967
    Liked
    1 times
    Quote Originally Posted by Ronald Roe View Post
    Looks good to me. I will say, when you are setting a background color or image, it's best to set them explicitly. Oddly, when you use shorthand, it sets a lot of defaults that aren't the same as the default browser styles, and may cause further issues down the line if another selector overwrites those values.

    I can't find the original article I read, which explains it much better and with really good examples, but I did find this one that does an overall adequate job of it: https://csswizardry.com/2016/12/css-...-anti-pattern/

    Probably not a real issue in a small learning project like this, but something to keep in mind as you step into real world projects.
    Thanks! Like this?
    https://developer.mozilla.org/en-US/...CSS/background

  5. #4
    Junior Member
    Join Date
    Dec 2016
    Posts
    17
    Member #
    55967
    Liked
    1 times
    Just got it, thanks!


Remove Ads

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
All times are GMT -6. The time now is 12:50 PM.
Powered by vBulletin® Version 4.2.3
Copyright © 2019 vBulletin Solutions, Inc. All rights reserved.
vBulletin Skin By: PurevB.com