window.location & onsubmit=

[Tomaszewski]

hi, i have this little issue, i'm trying to make the SIMPLEST google search for a cool little project and when i try to load a link via JS on form submit, it doesn't do anything. Changing the submit button to a type="button" and adding the event to that button onclick="function()" will work, but add the onsubmit="function()" to the <form> tag won't work. Can someone tell me why? Or how I can get it to work?



Why wont' this work?

//JS file
			function showSearchWord()
			{
				var googleSearch = "http://www.google.com/search?q=";
				var formsValue = document.getElementById("googleForm").value;
				window.location = googleSearch + formsValue;
			}

//html file
			<form name="myForm" onsubmit="showSearchWord()">
				<ul>
					<li>
					<input type="text" id="googleForm" name="inputForm" />
					<input type="submit" value="Search" />
					</li>
				</ul> 	
			</form>

... and why does this work?

//JS file
			function showSearchWord()
			{
				var googleSearch = "http://www.google.com/search?q=";
				var formsValue = document.getElementById("googleForm").value;
				window.location = googleSearch + formsValue;
			}

//html file
			<form name="myForm">
				<ul>
					<li>
					<input type="text" id="googleForm" name="inputForm" />
					<input type="button" value="Search" onclick="showSearchWord()"/>
					</li>
				</ul> 	
			</form>

[iphong]

This function needs to return false other why it will take you to the action page first before execute your code . In your case your action page is blank so it's automatically set to the current page.

and by the way, onsubmit does not work with Firefox though.

This should work:

// Javascript
function showSearchWord()
{
	var googleSearch = "http://www.google.com/search?q=";
	var formsValue = document.getElementById("googleForm").value;
	window.location = googleSearch + formsValue;
	
	return false;
}

//HTML
<form name="myForm" onsubmit="return showSearchWord();">
    <ul>
        <li>
        <input type="text" id="googleForm" name="inputForm" />
        <input type="submit" value="Search" />
        </li>
    </ul> 	
</form>