Please help me with form validation code.

[kingot]

Hi,
Please help me to correct this form validation code.it is not working when a field is left blank.Actually it fails to work.Here is it.

<script type="text/javascript">
function validateForm()
{

function CheckEmail()
var x=document.frmone.email.value;
var atpos=x.indexOf("@");
var dotpos=x.lastIndexOf(".");
if(atpos<1 || dotpos<atpos+2 ||x.length>30){
alert("not a valide email address");
return false
}


function Checkempty()
{
var x=document.frmone.fname.value;
if(x==null || x==""){
alert("username is required");
return false
}

Checkusername()
{
var user=document.f1.name.value;
var illegalchars=^W/; // allows only letters,numbers and underscorse
if(user.value==""){
alert("You did not enter ausername");
return false
}

if(illegalchars.test(user.value)){
alert("You did not enter ausername");
return false
}
if(user.value.length<5 || user.value.length>30){
alert("username is either less than 5 or more than 30);
return false
}
}
</script>
<form name="frmone" method="post" action="" onsubmit="return validateForm()"/>
Email: <input type="text" name="email"/>
Empty: <input type="text" name="fname"/>
username: <input type="text" name="name"/>
<input type="submit" value="submit form"/>
</form>

Please help.
Thanks.
Clement Osei.

[TheGAME1264]

First of all, you can't put functions inside of functions like that. You can call functions. But you can't put them inside of functions like that. So the easiest way to solve your problem may be just to remove the function lines and their closing brackets and get that to work.

Second, your user variable points to a form that doesn't exist.

If you're going to take code from other sites like you seem to have done, take it in small pieces so you can understand and debug it more easily.