Some help with functions and forms

[Crispian]

The code below I am trying to test for user to enter salary but when I enter a value less than 5000 or more than 4999 it still says You do not qualify for a credit card. Why? I tried various combinations of the comparison operators >, >=, <, <= and it still just fronted out "You do not qualify for a credit card"


Please help me with this. Thanks in advance.

<script type="text/javascript">        
                /* <=!=[=C=D=A=T=A=[ */
        /* ]=]=> */
            var salary = function(earnings) {
                
                if (document.getElementById(earnings) > 4999) {
                    alert("You qualify for a credit card! Please come in.");
                } else if (document.getElementById(earnings) < 5000 ) {    
                    alert("You do not qualify for a credit card");
                } else {
                    alert("You did not enter anything");
                }
                
            };
            
        </script>

<form action="">            
<p><input type="text" placeholder="Enter salary" maxlength="30" id="earnings" /></p>            
<p><input type="submit" value="Enter" onclick="salary(earnings)" /></p>                    
</form>

[TheGAME1264]

You're entering earnings as a variable when you don't have to.

Change your onclick to this:

salary(document.getElementById('earnings'))

That will pass the field itself to the salary function, rather than a variable with nothing in it.
Then change your function to this (notice how "salary" isn't a variable):

function salary(earningsField) {
      var earnings = earningsField.value; / * this will get the value from the field.  I'll leave the rest up to you. */
}

[Crispian]

Great. Thanks much

Here is what I did.

var salary = function() { // I removed the earnings parameter and changed it to a variable inside the function                       var earnings = document.getElementById('earnings').value; // earnings variable to retrieve values entered 
                
                if (earnings > 4999) { //and just used the variable earnings here instead of the doc.ElementById();
                    alert("You qualify for a credit card! Please come in.");
                } else if (earnings < 5000) {    
                    alert("You do not qualify for a credit card");
                } else {
                    alert("You did not enter anything");
                }
            };

<form action="">
<p><input type="text" placeholder="Enter salary" maxlength="30" id="earnings"/></p>       
<p><input type="submit" value="Enter" onclick="salary(document.getElementById('earnings'))" /></p>           
</form>

[TheGAME1264]

I'm not sure why you're declaring salary as a variable (or even if it works...never tried it before), but if it works for you, then go for it I guess. Personally, I prefer function salary () so that I know it's a function when I read my code from left to right. But again, if that worked, cool.