Can't find Syntax Error on line 7 in my coding

**James92** · Nov 17th, 2014, 02:48 PM

// JavaScript Document

<script language="JavaScript">
var slideimages=new Array()
var slidelinks=new Array()
function slideshowimages(){
for (i=0;i<slideshowimages.arguments.length;i++){
slideimages[i]=new Image()
slideimages[i].src=slideshowimages.arguments[i]
}
}

function slideshowlinks(){
for (i=0;i<slideshowlinks.arguments.length;i++)
slidelinks[i]=slideshowlinks.arguments[i]
}

function gotoshow(){
if (!window.winslide||winslide.closed)
winslide=window.open(slidelinks[whichlink])
else
winslide.location=slidelinks[whichlink]
winslide.focus()
}

//-->
</script>

**Web Design Forums** · Nov 17th, 2014 02:48 PM

**Ronald Roe** · Nov 17th, 2014, 03:22 PM

There are a number of errors in your code.

1. You have zero semi colons at the end of your statements.

2. Your for loop in slideshowlinks() doesn't have an opening bracket

3. Your conditional in gotoshow() doesn't have proper brackets

An as a bonus non-error, but matter of good coding practice: you don't need to use the Array constructor. The variable constructors were added to help native language programmers be comfortable with JS. Define an empty array like so:

Code:

var slideimages =[];

**James92** · Nov 17th, 2014, 04:52 PM

Still getting the syntax error on this line

for (i=0;i<slideshowimages.arguments.length;i++){
slideimages[i]=new Image()
slideimages[i].src=slideshowimages.arguments[i]
}
}

**Ronald Roe** · Nov 17th, 2014, 09:09 PM

You're still missing you semi colons.
What is the specific error?

**James92** · Nov 17th, 2014, 10:22 PM

It just says (There is a syntax error on line 7.Code hinting may not work until you fix this error.) That's the error message I am getting in Dreamweaver CS6.

**TheGAME1264** · Nov 17th, 2014, 11:31 PM

I don't know where or how you got those functions, but they're both messed up in context. It looks like you're supposed to pass arrays to each of the functions to get them to work, but I don't see how you're doing that.

Upload the page you're doing this for and let's see it, although the logical and simplest thing to do to start would be something like this: slideimages = ["image1.jpg", "image2.jpg", "image3.jpg"] as opposed to calling some function to make things more complicated than they need to be.

**sasha_bolcina** · Nov 18th, 2014, 02:37 AM

Are you sure 'slideshowimages' object contains data? Test it before loop with alert(slideshowimages.arguments.length). If you got error or undefined, thats it...

**Ronald Roe** · Nov 18th, 2014, 07:42 AM

I feel like we're probably missing some of the script. If I fix the minor syntax errors and run it in the console, I don't get any errors, but all of the variables are empty, which is expected. GAME covered that one. However, Image isn't a data type, so it would have had to be an object defined elsewhere. That part is either missing or hasn't been defined yet. I was surprised to find that didn't throw an error, though.

**James92** · Nov 18th, 2014, 10:48 AM

Here's my code I changed the JS Code no more syntax errors need help to finish it so it can work.

Source Code

HTML Code:

<!DOCTYPE html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Vacation Website</title>

<!--[if It IE 9]>
<script src="js/html5shiv.js"></script>
<![endif]-->

<link href="css/style.css" rel="stylesheet" type="text/css">
<script type="text/javascript" src="js/vacation.js"></script>
</head>



<body>


<div id="wrapper"><!--This will help center the page-->


<header> <a href="javascript:gotoshow()"><img src="miami2.jpg" name="slide" border=0 width=900 height=184></a>
<script>
<!--

//configure the paths of the images, plus corresponding target links
slideshowimages("miami2.jpg","australia2.jpg","venice2.jpg","lasvegas.jpg")
slideshowlinks("file:///C:/Users/James/Desktop/Vacation%20Website/images/miami2.jpg","file:///C:/Users/James/Desktop/Vacation%20Website/images/australia2.jpg","file:///C:/Users/James/Desktop/Vacation%20Website/images/venice2.jpg","file:///C:/Users/James/Desktop/Vacation%20Website/images/lasvegas.jpg")

//configure the speed of the slideshow, in miliseconds
var slideshowspeed=2000

var whichlink=0
var whichimage=0
function slideit(){
if (!document.images)
return
document.images.slide.src=slideimages[whichimage].src
whichlink=whichimage
if (whichimage<slideimages.length-1)
whichimage++
else
whichimage=0
setTimeout("slideit()",slideshowspeed)
}
slideit()

//-->
</script> </header>

<nav>Home | Flights | Hotels | Cruises | Vacation Packages | Contact Us</nav>
<br>

<section id class="sec1">

<h1> </h1>

<p>this is where rollover image will be </p>

</section>

<section id class="sec2">

<h1> </h1>

<p>this is where rollover image will be </p>

</section>

<section id class="sec3">


<p>this is where rollover image will be </p>
</section>

<article>
<h2>Featured Hotel Deals</h2>

<p>

The perfect vacation starts with the perfect place to stay. Browse our selection of cheap hotels to find the five-star spots or intimate inns of your dreams. We'll even let you compare prices on your favorites and see how the hotels rank with fellow travelers. No matter if you are looking for a place to crash or seek the top-notch amenities for your getaway, Expedia has what you are looking for.</p>

    <p>Niagara Falls Hotels
    Hotel Deals in Banff
    Popular Hotels in Calgary
    Ottawa Hotel Destinations
    Toronto Hotel Deals
    Hotels in Vancouver
    Top Montreal Hotels
    Popular Edmonton Hotels</p>


<p>Calling all fliers: If you're searching for inexpensive airline tickets, Expedia.ca is the place to be. Jet off to any corner of the globe with our unbeatable selection of flights and airfare. Search for flights by time or carrier, look for the cheapest or most luxurious airline. Expedia has you covered for your next take-off wherever your destination may be.</p>

    <p>Cheap Flights to Hawaii
    Flights to Las Vegas
    Cheap Tickets to London
    Flight to Calgary
    New York Flights
    Cheap Tickets to Toronto
    Flights to Vancouver
    Orlando Flight Deals</p>

<h2>Cheap Flights</h2>

<img src="http://www.webdesignforums.net/forum/images/plane.jpg" width="335" height="189" alt="plane">
<p>Everyone needs an occasional escape. Uncover a world of vacations with Expedia's packages and trip ideas. From secluded getaways to all inclusive vacations, we offer up-to-date deals on the most popular trips. No matter if you prefer to vacation in the latest hot spot or wish to hide in deep wilderness, Expedia offers the perfect fit for your vacation style.</p>

<h2>Cheap Last Minute Vacations & All Inclusive Vacation Packages</h2>

<p>Cheap last minute vacations combine excitement, spontaneity, unexpected discovery, and best of all, savings. SellOffVacations.com offers a full range of deals on cheap last minute vacations and all inclusive vacation packages for travellers with flexibility and a sense of adventure. Choose from a wide selection of great deals to some of the most popular vacation destinations and enjoy an affordable dream vacation. Take advantage of our last minute vacation search option or check out some of our best last minute vacation deals below and discover the thrill of travel on the fly. If you've got the urge to get away now, SellOffVacations.com can help you make it happen for the best price.</p>

    <p>Cuba Vacations
    Mexico All Inclusive
    New York Vacations
    Las Vegas Vacations
    Costa Rica Vacations
    Hawaii vacations
    Jamaica All Inclusive
    Dominican Republic All Inclusive</p>

<h2>Vacation Packages</h2>

<p>Need to rent a car? We've got you covered. With Expedia's car rental deals, you can drive from coast to coast without breaking the bank. Get ready to hit the road. Enjoy the freedom of being able to stop and smell the roses on your road trip – no matter if you are driving to visit relatives in the next town over or somewhere across the country. Expedia has rental cars available at the locations most convenient for you.</p>

    <p>Toronto Car Rental
    Ottawa Car Rental
    Car Rental Montreal
    Cheap Car Rental Las Vegas
    Car Rental in Vancouver
    Car Rentals Calgary
    Rental Cars Edmonton
    Halifax Rent a Car</p>

<h2>Deals on Car Rental</h2>

<p>Explore the world's most unforgettable ports-of-call with our selection of cruises, packages, and cruise deals. Thanks to Expedia, sailing the high seas has never been easier. Make discovering the high seas your new tradition. With Expedia's unbeatable prices anyone can afford to become a seafarer. Peruse the myriad of cruises available for any occasion and book your next journey today.</p>
    
     <h2> Popular Cruise Destinations </h2>
    
    <p>Alaska Cruises
    Panama Canal Cruise
    Cruises to Hawaii
    Bermuda Cruise Deals
    Repositioning Cruises
    Cruise Caribbean
    Cruises in South America
    Cruise Destinations in Europe</p>
</p>

<h2>Cheap Cruises, Deals & Discounts</h2>


<p>Use our handy search engine to find a broad selection of cheap cruises or call and speak to one our SellOffVacations.com travel representatives.</p>





<h2>Travel Insurance Canada</h2>


<p>Stay protected when you travel with our Manulife Travel Insurance plans. </p>


<h2>Why Purchase Travel Insurance?</h2>

<p>There are many excellent reasons to purchase travel insurance when travelling abroad. Consider these cases when deciding on travel insurance for Canadians:</p>
 <ul>
  <li>Your credit card coverage may be limited and may not protect your entire travel costs and investment</li>
  <li>Your group policy through your workplace may not cover all your insurance needs</li>
  <li>Your government health insurance plan will not protect you when travelling abroad</li>
  <li>You may need coverage for a variety of situations which are not covered by your current insurance plan</li>

</ul> 
  


<footer> <h4>© 2014 Enjoy Relax JMB Travel, Inc. All rights reserved.</h4> 
</footer>













</div><!--Ends Wrapper-->
</body>
</html>

CSS Code

Code:

/* CSS Document */

h1,h2,h3,h4,h5,h6,body,header,footer,nav,section,article,html,div,video,audio { }



* {
    padding-right: 20px;
    padding-left: 20px;
    margin-right: 20px;
    margin-left: 20px;
    padding-top: 5px;
    padding-bottom: 5px;
    margin-top: 5px;
    margin-bottom: 5px;
}
#wrapper {
    background-color: #09F;
}


header {
    background-color: #09F;
    height: 10em;
    background-image: url(../images/miami2.jpg);
    background-repeat: no-repeat;
    background-position: center center;
    text-align: center;
   
   
}


header h1{
}
nav {
    background-color: #FFF;
    float: left;
}




body {
    background-color: #0CF;
}


article {
    background-color: #09F;
}



footer {
    background-color: #09F;
}
footer h4 {
    text-align: center;
}

JS Code

Code:

var Image_slide = new Array("miami2.jpg", "australia2.jpg", "venice2.jpg","lasvegas.jpg");// image container
var Img_Length  = Image_slide.length; // container length - 1
var Img_current = 0

function slide() {
    if(Img_current >= Img_Length) {
        Img_current = 0;
    }
    document.slideshow.src = Image_slide[Img_current];
    Img_current++;
}
function auto(){
    setInterval(slide, 1000);
}
window.onload = auto;

**Vapr_Arts** · Nov 18th, 2014, 06:41 PM

Do you have something against semicolons? There are none in your js and there should be!

Regretfully sent from my iPhone using Tapatalk during lunch and other breaks

Thread: Can't find Syntax Error on line 7 in my coding

LinkBack

Thread Tools

Search Thread

Display