counter in do/while loop broke my page

mikedfunk · February 13 '04, 12:26 AM (#1)

I'm trying to insert a counter that lets me do a repeating region of MySQL query results, displayed in 3 columns then going to the next row and starting over. Like a table of results. I thought I had the code right but now my page won't display at all. First I went to the first appearing <?php area in my page, making sure it wasn't inside any loops, and inserted on separate lines:

PHP Code:


			
$counter = 0;

$columns = 0;

My code, generated by dreamweaver as a horizontal repeating region, is in a do/while loop:

PHP Code:


			
<table width="200" border="1" cellspacing="2" cellpadding="5">

  <tr>

    <?php do { ?>

    <td><span class="header1"><a href="/closeups/<?php echo $row_mostRecent['picture_id']; ?>"><img src="/thumbs/<?php echo $row_mostRecent['picture_URL']; ?>" border="0"><span class="header2"><br>

      </span></a><span class="header2"><a href="closeups/<?php echo $row_mostRecent['picture_id']; ?>"><?php echo $row_mostRecent['picture_title']; ?> </a> <br>

  Size: <?php echo $row_mostRecent['picture_size']; ?><br>

  Viewed <?php echo $row_mostRecent['picture_viewCount']; ?> times<br>

  Created: </span><span class="header2"><?php echo $row_mostRecent['picture_createdWhen']; ?>

  </span></span></td>

This is where I put my counter that broke the page:

PHP Code:


			
<?php 

    $counter++;

    if_($counter_==_$columns)

    {

    $counter_=_0;

    echo_"</tr><tr>";

    }

    ?>

And the code finishes up...

PHP Code:


			
    <?php } while ($row_mostRecent = mysql_fetch_assoc($mostRecent)); ?>

  </tr>

</table>

Shouldn't this work? Shouldn't a ++ thingy work in that location since it is inside the "do" part of the do/while function? What am I doing wrong?

bwedekin · February 13 '04, 12:10 PM (#2)

What is the counter for?

mikedfunk · February 13 '04, 02:14 PM (#3)

I am trying to dynamically display a Picture, it's name, when it was last updated, and then to the right of that another picture, etc. I want to limit it to 3 pictures horizontally and then go to the next row down and start to do another row.

See To view the link you have to Register to view an example of what I mean.

Any suggestions?

Elroy · February 13 '04, 05:56 PM (#4)

I see some _ (underline) in your codes below "counter++". You don't need them, for what I know.

Quote:

<?php } while ($row_mostRecent = mysql_fetch_assoc($mostRecent)); ?>

Try put a "==" there instead of "=". Inside the while() thing you are comparing the two variables, yea?

Hope it helps.

**rosland** · February 13 '04, 07:38 PM (#5)

Did the code work before you altered it with the counter (displaying everything on one row it appears)?

Don't change the "=" to "==" in the while statement, that will destroy the boleean logic. With one "=" sign, it's telling the program to stay in the loop as long as query is retrieving data. When the internal 'while' iterator reaches the last result set, it comes up 'false' and the loop breaks.

You counter doesn't make sense though. (I don't know if it's WDF that inserts all the underscore lines, but if they exist in your code you should remove them.) In your If statement you're comparing $counter to $column which are both set to '0' on top of your script. That means the clause will never be true as the value of "$counter" will have the value of 1 the first time the comparison is made, and thereafter only increase.

What you could do is:

PHP Code:


			
# Change $columns=0 to $i=0 outside loop to begin with

$counter++;

$i++;

if ($counter==3)

 {

   # The while clause is to prevent an empty <tr> after last image

   while ($i<mysql_num_rows($mostRecent))

    {

      echo "</tr>\n<tr>";

      $counter=0;

    }

 }

EDIT:
In the future when you make a post containing either the PHP or CODE BB-tags, be aware that WDF ignores word wrapping for any text inside these tags. That means that your posted code will expand the column to fit the length of the text line. If you write a 6 feet long line without a line break, then we will have to scroll 6 feet horizontally to read your post

mikedfunk · February 14 '04, 08:20 PM (#6)

I fixed it. It seems I had a few problems.

1. In Dreamweaver's code view, I had typed a few spaces in certain areas. Instead of inserting spaces, Dreamweaver inserted the ascii character for the dagger.

2. In my code for the variables at the top, I forgot a $ before one of the variables.

3. I see what you're saying about comparing the $counter with the $columns and them both being zero. That's not the way it actually was in the code; the $columns was set to 5. I typed it in wrong in the forum.

Thanks for all the help, though, you all did make some things clearer!